refactor: Replace class strings with ::class constants #48047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
requested review from
miaulalala,
nickvergessen,
st3iny and
tcitworld
as code owners
miaulalala
approved these changes
Sep 15, 2024
Signed-off-by: Christoph Wurst <[email protected]>
st3iny
approved these changes
Sep 15, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Psalm found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
nickvergessen
requested changes
Sep 16, 2024
| @@ -725,7 +725,7 @@ public static function init(): void { | |||
| \OCP\Util::connectHook( | |||
| '\OCA\Files_Sharing\API\Server2Server', | |||
| 'preLoginNameUsedAsUserName', | |||
| '\OC\User\Database', | |||
| \OC\User\Database::class, | |||
There was a problem hiding this comment.
This should breaking the events:
https://3v4l.org/ccpQf
If you adjusted the original event to also no longer provide the \ old listeners will be broken.
Same for the listen() emitter things.
Potential solution: strip leading slashes when listeners and emits are down inside Util/Emitter-trait
skjnldsv
added
2. developing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist